Skip to content

Conversation

@amiclaus
Copy link
Contributor

@amiclaus amiclaus commented Mar 24, 2025

Description

Add pyadi-iio support for ad9508 device.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware: AD4880 Evaluation Board
  • OS: Linux

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@amiclaus amiclaus self-assigned this Mar 24, 2025
@github-actions
Copy link

Generated documentation for this PR is available at Link

@github-actions
Copy link

github-actions bot commented Mar 24, 2025

Test Results

1 714 tests  ±0     462 ✅ ±0   12m 2s ⏱️ -2s
    1 suites ±0   1 252 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit c88aa91. ± Comparison against base commit b89168a.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[0.5, 11.0, 33.0, 31.0, 30.0, 14.0, 11.0, 4.0, 10.5, 1.0]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[8.0, 7.0, 12.0, 5.0, 19.5, 21.5, 25.0, 19.5, 24.5, 24.5]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-32.7, -23.7, -3.0, -31.25, -6.9, -28.45, -1.05, -18.0, -19.4, -1.45]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-5.55, -17.9, -11.85, -33.15, -25.7, -37.1, -16.25, -2.5, -29.4, -22.25]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[27.5, 18.0, 10.5, 6.0, 1.5, 18.0, 26.5, 1.0, 14.5, 14.5]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[6.5, 18.5, 25.0, 25.5, 12.5, 22.5, 18.5, 22.5, 19.0, 3.0]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-19.45, -7.8, -25.75, -4.65, -9.0, -11.0, -13.15, -23.95, -16.8, -12.25]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-30.65, -32.2, -13.3, -8.9, -37.85, -11.4, -7.05, -31.7, -7.75, -22.45]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2:

  • add docstrings
  • rebase with main branch to get the build fixes.

Copy link
Contributor Author

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3:

  • make sure that all channel attributes are output

Add pyadi-iio support for ad9508 device.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Copy link
Contributor Author

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4:

  • solve new conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants