Skip to content

Add README documentation for AD9467 #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add README documentation for AD9467 #2615

wants to merge 1 commit into from

Conversation

rey188
Copy link

@rey188 rey188 commented May 28, 2025

Pull Request Description

Adding project documentations for AD9467.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have complied with the Submission Checklist
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

@CLAassistant
Copy link

CLAassistant commented May 28, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

amiclaus
amiclaus requested changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please properly set the commit title and body. see other documentation commits as example:
0ac1ec3

@rey188
drivers: adc: ad9467: Add README documentation for ad9467
926b9e4 
Added the README file for ad9467 driver.

Modified the sphinx drivers_doc.rst file to add the corresponding source

Signed-off-by: Reymond Olmedo <reymond.olmedo@analog.com>
@rey188
Copy link
Author

rey188 commented Jun 3, 2025

V2

  • edited the commit title and body of the previous version

amiclaus
amiclaus reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/AzurePipelines run

@amiclaus
Copy link
Contributor

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

buha
buha reviewed Jun 17, 2025
View reviewed changes
doc/sphinx/source/drivers_doc.rst
@@ -25,6 +25,7 @@ ANALOG TO DIGITAL CONVERTERS
drivers/ad7768-1
drivers/ad9083
drivers/ad9208
drivers/ad9467
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please rebase on main ? there should be an updated drivers_doc.rst which adds blank lines between these entries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buha buha buha left review comments

@amiclaus amiclaus amiclaus approved these changes

@CiprianRegus CiprianRegus Awaiting requested review from CiprianRegus CiprianRegus is a code owner

@dbogdan dbogdan Awaiting requested review from dbogdan dbogdan is a code owner

@rbolboac rbolboac Awaiting requested review from rbolboac rbolboac is a code owner

@danmois danmois Awaiting requested review from danmois danmois is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rey188 @CLAassistant @amiclaus @buha