iio: adc: ad4130: Fix clock init and GPIO init. #2842
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronkis
requested review from
nunojsa,
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
danmois,
CiprianRegus and
machschmitt
as code owners
There is an error while probing the AD4130. The clk_init_data has to be initialized as an empty struct otherwise the probe will fail. There is an error assigning the functions of GPIO pins. Before setting the GPIO as an output, the GPIO has to be verified if it does not already has a function. Signed-off-by: Aron Kis <kis.aron@analog.com>
nunojsa
reviewed
Jul 9, 2025
There was a problem hiding this comment.
This looks good. However, you're missing fixes tag (this is a fix) and in theory you're fixing two different issues. They are simple enough that might be acceptable to go in the same patch though.
Anyways, this driver is upstream and it seems it has the same issues so please send this patch upstream (and then we can merge it in our tree)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
There is an error while probing the AD4130. The clk_init_data has to be initialized as an empty struct otherwise the probe will fail.
There is an error assigning the functions of GPIO pins. Before setting the GPIO as an output, the GPIO has to be verified if it does not already has a function.
PR Type
PR Checklist