Skip to content

Update ad9208.c #2814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update ad9208.c #2814

wants to merge 1 commit into from

Conversation

JIH82
Copy link

@JIH82 JIH82 commented Jun 6, 2025

changed clock rates to support -625 variant these were 625e6 phy->ad9208.input_clk_min_hz = 240000000ULL;
phy->ad9208.adc_clk_min_hz = 240000000ULL;

PR Description

  • Please replace this comment with a summary of your changes, and add any context
    necessary to understand them. List any dependencies required for this change.
  • To check the checkboxes below, insert a 'x' between square brackets (without
    any space), or simply check them after publishing the PR.
  • If you changes include a breaking change, please specify dependent PRs in the
    description and try to push all related PRs simultaneously.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

changed clock rates to support -625 variant these were 625e6
phy->ad9208.input_clk_min_hz = 240000000ULL;
phy->ad9208.adc_clk_min_hz = 240000000ULL;
Copy link
Contributor

@machschmitt machschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JIH82,

The code change in itself makes sense to me.
The commit needs some adjustments, though.
Add your sign-of-by tag. git commit -s does that automatically for you.
You may need to update/set up the .gitconfig file with your user info (name and email).
The commit message/title and body also needs updating.
iio: adc: ad9208: Decrease minimum clock to support 625 MSPS operation mode
would be something more kernel-like style. See other commits in the kernel repo for more examples. See https://cbea.ms/git-commit/#why-not-how for some tips on how to write nice commit logs. Telling the datasheet page where the clock specifications are would also help reviewers quickly find the constant you are updating.

@nunojsa
Copy link
Collaborator

nunojsa commented Jul 8, 2025

Hi @JIH82,

On top of what Marcelo stated, the commit message is confusing. From a brief look into the datasheet, it seems this is an actual fix since the minimum clock rate for both -625 ad -1300 variants seems to be 240MHz. Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants