-
Notifications
You must be signed in to change notification settings - Fork 892
Add support for AD4052 ADC Family #2642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mirror/jic23/iio/testing
Are you sure you want to change the base?
Conversation
ce15fe8
to
86e6d7c
Compare
Forced pushed to:
Forced pushed (2) to:
Forced pushed (3) to:
|
1f5b827
to
9611c42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it goes first round of review...
I think this one can be upstreamed without the offload bits
4b81da9
to
494d89f
Compare
Change log v0 -> v1 Review changes:
New:
Design changes:
|
drivers/iio/adc/Kconfig
Outdated
tristate "Analog Devices AD4052 Driver" | ||
depends on SPI | ||
depends on PWM | ||
depends on GPIOLIB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not sure if gpio is something you should depend on or just select it. I think the single shot reading could be something useful to have even more to make this driver more upstreamable without offload support (we can still some questions about it though).
drivers/iio/adc/Kconfig
Outdated
tristate "Analog Devices AD4052 Driver" | ||
depends on SPI | ||
depends on PWM | ||
depends on GPIOLIB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also one not on the commit message. Style is iio: adc: ...
. Drop the drivers:
if (val == 0) { | ||
st->mode = AD4052_SAMPLE_MODE; | ||
} else { | ||
st->mode = AD4052_BURST_AVERAGING_MODE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would double check other examples of oversampling. To me this is a 1 or 0 thing. Either it's enabled it not. Your mode variable also just seems to have two states here so the way you're handling val
raises some questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The device supports from 2 to 4096 in powers of 2 samples for avg mode.
Decided to reserve 0 and 1 to disable the feature (return to sample mode)
494d89f
to
03cfbc9
Compare
Change log v1 -> v2 Review changes:
Changes:
Extra force push to resolve merge conflict |
03cfbc9
to
a7eca14
Compare
eb23140
to
0506d4c
Compare
b5616ca
to
6247b30
Compare
82b78d9
to
aa36d77
Compare
0cf4b64
to
21d6db3
Compare
7cb13b5
to
09c3845
Compare
23e6418
to
cb72b0b
Compare
Changes to backport to main
PR Type
PR Checklist