misc: xilinx-ai-engine: Remove extra of_node_get in aperture probe

for_each_available_child_of_node() in of_xilinx_ai_engine_aperture_probe
calls of_node_get() internally. Driver does not need to call of_node_get
and increment the refcounter again. This causes

[  510.309943] OF: ERROR: memory leak, expected refcount 1 instead of 2, of_node_get()/of_node_put() unbalanced - destroy cset entry: attach overlay node /axi/ai_engine@20000000000

Remove of_node_get() in aperture probe and call of_node_put() in case of
aperture probe failure.

Signed-off-by: Govindarajulu Varadarajan <govindarajulu.varadarajan@amd.com>
Message-ID: <20241029011708.2154933-1-govindarajulu.varadarajan@amd.com>

Author: govind-varadar

drivers/misc/xilinx-ai-engine/ai-engine-aperture.c

@@ -580,8 +580,6 @@ of_aie_aperture_probe(struct aie_device *adev, struct device_node *nc)
 		goto put_aperture_dev;
 	}
 
-	of_node_get(nc);
-
 	ret = aie_aperture_sysfs_create_entries(aperture);
 	if (ret) {
 		dev_err(dev, "Failed to create aperture sysfs: %d\n", ret);

drivers/misc/xilinx-ai-engine/ai-engine-dev.c

@@ -470,6 +470,7 @@ void of_xilinx_ai_engine_aperture_probe(struct aie_device *adev)
 			dev_err(&adev->dev,
 				"Failed to probe AI engine aperture for %pOF\n",
 				nc);
+			of_node_put(nc);
 			/* try to probe the next node */
 			continue;
 		}