Revert "crypto: zynqmp-aes-gcm: Initialise key source before use"

This reverts commit d9fe55e.

zynqmp-aes-gcm self-test fails with below kernel warning. So for now
revert the key source initialization to fix zynqmp regressions.

zynqmp-aes zynqmp-aes.0: ERROR: Wrong KeySrc, enable secure mode
alg: aead: zynqmp-aes-gcm encryption failed on test vector 1;
expected_error=0, actual_error=-19, cfg="in-place (one sglist)"
alg: self-tests for gcm(aes) using zynqmp-aes-gcm failed (rc=-19)
------------[ cut here ]------------
alg: self-tests for gcm(aes) using zynqmp-aes-gcm failed (rc=-19)
WARNING: CPU: 2 PID: 80 at crypto/testmgr.c:5943 alg_test+0x43c/0x54c

Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Message-ID: <20241028111311.1238477-1-radhey.shyam.pandey@amd.com>

Author: Radhey Shyam Pandey

drivers/crypto/xilinx/zynqmp-aes-gcm.c

@@ -510,6 +510,12 @@ static int versal_aes_aead_setkey(struct crypto_aead *aead, const u8 *key,
 				memcpy(tfm_ctx->key, key, keylen);
 			}
 		}
+
+		if (tfm_ctx->keysrc < VERSAL_AES_EFUSE_USER_KEY_0 ||
+		    tfm_ctx->keysrc > VERSAL_AES_USER_KEY_7 ||
+		    tfm_ctx->keysrc ==  VERSAL_AES_KUP_KEY) {
+			tfm_ctx->keysrc = VERSAL_AES_USER_KEY_0;
+		}
 	}
 
 	tfm_ctx->fbk_cipher->base.crt_flags &= ~CRYPTO_TFM_REQ_MASK;
@@ -576,7 +582,7 @@ static int aes_aead_init(struct crypto_aead *aead)
 		       __func__, drv_ctx->aead.base.base.cra_name);
 		return PTR_ERR(tfm_ctx->fbk_cipher);
 	}
-	tfm_ctx->keysrc = VERSAL_AES_USER_KEY_0;
+
 	crypto_aead_set_reqsize(aead,
 				max(sizeof(struct zynqmp_aead_req_ctx),
 				    sizeof(struct aead_request) +