Skip to content

Update READMEs with VADJ/VIO info for ad469x_evb #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mandrica
Copy link
Collaborator

@mandrica mandrica commented Jul 2, 2025

PR Description

Added VADJ/VIO info for ad469x_evb project.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@mandrica mandrica requested review from sarpadi and ladace as code owners July 2, 2025 14:02
@mandrica mandrica added the doc label Jul 2, 2025
StancaPop
StancaPop previously approved these changes Jul 2, 2025
ladace
ladace previously approved these changes Jul 2, 2025
Copy link
Contributor

@ladace ladace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No remarks found

Comment on lines 8 to 9
- Evaluation board for EVAL-AD4696 VADJ range: 1.2V - 1.8V
- Evaluation board for EVAL-AD4692 VIO: 3.3V
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Evaluation board for EVAL-AD4696 VADJ range: 1.2V - 1.8V
- Evaluation board for EVAL-AD4692 VIO: 3.3V
- Evaluation board VADJ range for EVAL-AD4696: 1.2V - 1.8V
- Evaluation board VIO for EVAL-AD4692: 3.3V

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -1,5 +1,9 @@
<!-- no_build_example, no_dts, no_no_os -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- no_build_example, no_dts, no_no_os -->
<!-- no_dts, no_no_os -->

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mandrica mandrica dismissed stale reviews from ladace and StancaPop via da9d28c July 8, 2025 14:46
@mandrica mandrica force-pushed the readme_ad469x_evb branch from 4d57698 to da9d28c Compare July 8, 2025 14:46
@@ -1,5 +1,9 @@
<!-- no_build_example, no_dts, no_no_os -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- no_build_example, no_dts, no_no_os -->
<!-- no_dts, no_no_os -->

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -1,5 +1,9 @@
<!-- no_build_example, no_dts, no_no_os -->

# AD469X-FMC/DE10NANO HDL Project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# AD469X-FMC/DE10NANO HDL Project
# AD469X-EVB/DE10NANO HDL Project

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment on lines 1 to 3
<!-- no_build_example, no_no_os -->

# AD469X-FMC/ZED HDL Project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- no_build_example, no_no_os -->
# AD469X-FMC/ZED HDL Project
<!-- no_no_os -->
# AD469X-EVB/ZED HDL Project

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mandrica mandrica force-pushed the readme_ad469x_evb branch from da9d28c to 3b7ee7c Compare July 9, 2025 08:16
@mandrica mandrica force-pushed the readme_ad469x_evb branch from 3b7ee7c to fd3f5f5 Compare July 9, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants