Skip to content

Update READMEs with VADJ info and modify the IOSTANDARD from LVCMOS25 to LVCMOS33 for pulsar_adc #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mandrica
Copy link
Collaborator

@mandrica mandrica commented Jun 30, 2025

PR Description

Added VADJ info and modify the IOSTANDARD from LVCMOS25 to LVCMOS33 for pulsar_adc project.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@mandrica mandrica added cosmetics The changes are not functional. doc and removed cosmetics The changes are not functional. labels Jun 30, 2025
@mandrica mandrica requested a review from IuliaCMoldovan June 30, 2025 13:30
@mandrica mandrica force-pushed the readme_pulsar_adc_vadj branch from 0464e65 to 6b38d82 Compare July 1, 2025 06:15
@mandrica mandrica force-pushed the readme_pulsar_adc_vadj branch 3 times, most recently from 5426c44 to ca737de Compare July 2, 2025 13:14
@mandrica mandrica force-pushed the readme_pulsar_adc_vadj branch 2 times, most recently from b877e21 to 4b23118 Compare July 9, 2025 08:55

## Building the project

- VIO with which it was tested in hardware: 3.3V
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved above the Building the project section

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

# Define SPI clock
create_clock -name spi0_clk -period 40 [get_pins -hier */EMIOSPI0SCLKO]
create_clock -name spi1_clk -period 40 [get_pins -hier */EMIOSPI1SCLKO]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the empty line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the copyright year

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mandrica mandrica force-pushed the readme_pulsar_adc_vadj branch from 4b23118 to 80cf0ff Compare July 9, 2025 10:20
@mandrica mandrica force-pushed the readme_pulsar_adc_vadj branch from 80cf0ff to db3c506 Compare July 9, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants