Skip to content

docs/library/axi_ad408x: Registers update #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs/library/axi_ad408x: Registers update #1678

wants to merge 1 commit into from

Conversation

PopPaul2021
Copy link
Contributor

PR Description

Add additional clarification for the registers function and removing self_sync bit.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@PopPaul2021
docs/library/axi_ad408x: Registers update
154ea7f 
Add additional clarification for the registers
function and removing self_sync bit.

Signed-off-by: PopPaul2021 <paul.pop@analog.com>
@PopPaul2021 PopPaul2021 requested a review from Villyam April 16, 2025 07:01
Villyam
Villyam approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@Villyam Villyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Villyam
Villyam reviewed Apr 16, 2025
View reviewed changes
docs/library/axi_ad408x/index.rst

.. note::

\* The register already exist in ADC Common. This is just a detailed explanation.

Software Suppport
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually you could remove the excess 'p'.

Suggested change
Software Suppport
Software Support

IuliaCMoldovan
IuliaCMoldovan reviewed Apr 16, 2025
View reviewed changes
docs/library/axi_ad408x/index.rst

.. note::

\* The register already exist in ADC Common. This is just a detailed explanation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
\* The register already exist in ADC Common. This is just a detailed explanation.
\* These registers already exist in ADC Common. This is just a detailed explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IuliaCMoldovan IuliaCMoldovan IuliaCMoldovan left review comments

@Villyam Villyam Villyam approved these changes

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PopPaul2021 @IuliaCMoldovan @Villyam