Skip to content

Commit 47a9cee

Browse files
committed
library: fix wrong reset polarity role for altera IP
Quartus detects reset polarity from the signal role, and inserts adapaters automatically. The IP affected by this commit were previously assigning the wrong (active high) polarity to active-low resets. This can cause multiple problems. The i3c controller and spi engine resets are generated by other IPs in the framework, and these were also detected as wrong polarity, hence it being undetected so far. Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
1 parent e2f45ef commit 47a9cee

File tree

7 files changed

+13
-14
lines changed

7 files changed

+13
-14
lines changed

library/i3c_controller/i3c_controller_core/i3c_controller_core_hw.tcl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ proc p_elaboration {} {
3434

3535
# clock and reset interface
3636

37-
ad_interface clock clk input 1
38-
ad_interface reset reset_n input 1 if_clk
37+
ad_interface clock clk input 1
38+
ad_interface reset-n reset_n input 1 if_clk
3939

4040
add_interface sdo axi4stream end
4141
add_interface_port sdo sdo_ready tready output 1

library/i3c_controller/i3c_controller_host_interface/i3c_controller_host_interface_hw.tcl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ proc p_elaboration {} {
6666
set if_clk if_clk
6767
}
6868

69-
ad_interface reset reset_n output 1 $if_clk
69+
ad_interface reset-n reset_n output 1 $if_clk
7070

7171
ad_interface signal offload_trigger input 1 if_pwm
7272

library/spi_engine/axi_spi_engine/axi_spi_engine_hw.tcl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ proc p_elaboration {} {
5252
# Microprocessor interface
5353

5454
ad_interface clock up_clk input 1
55-
ad_interface reset up_rstn input 1 if_up_clk
55+
ad_interface reset-n up_rstn input 1 if_up_clk
5656
ad_interface signal up_wreq input 1
5757
ad_interface signal up_wack output 1
5858
ad_interface signal up_waddr input 14
@@ -115,8 +115,8 @@ proc p_elaboration {} {
115115

116116
# SPI Engine interfaces
117117

118-
ad_interface clock spi_clk input 1
119-
ad_interface reset spi_resetn output 1 if_spi_clk
118+
ad_interface clock spi_clk input 1
119+
ad_interface reset-n spi_resetn output 1 if_spi_clk
120120

121121
add_interface cmd axi4stream start
122122
add_interface_port cmd cmd_ready tready input 1

library/spi_engine/spi_engine_execution/spi_engine_execution_hw.tcl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ proc p_elaboration {} {
3232
# clock and reset interface
3333

3434
ad_interface clock clk input 1
35-
ad_interface reset resetn input 1 if_clk
35+
ad_interface reset-n resetn input 1 if_clk
3636

3737
ad_interface signal active output 1
3838

library/spi_engine/spi_engine_interconnect/spi_engine_interconnect_hw.tcl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ proc p_elaboration {} {
2323

2424
# clock and reset interface
2525

26-
ad_interface clock clk input 1
27-
ad_interface reset resetn input 1 if_clk
26+
ad_interface clock clk input 1
27+
ad_interface reset-n resetn input 1 if_clk
2828

2929
# command master interface
3030

library/spi_engine/spi_engine_offload/spi_engine_offload_hw.tcl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ proc p_elaboration {} {
3232
# control interface
3333

3434
ad_interface clock ctrl_clk input 1
35-
ad_interface reset spi_resetn input 1 if_spi_clk
3635

3736
add_interface ctrl_cmd_wr conduit end
3837
add_interface_port ctrl_cmd_wr ctrl_cmd_wr_en wre input 1
@@ -62,8 +61,8 @@ proc p_elaboration {} {
6261

6362
# SPI Engine interfaces
6463

65-
ad_interface clock spi_clk input 1
66-
ad_interface resetn spi_resetn input 1 if_spi_clk
64+
ad_interface clock spi_clk input 1
65+
ad_interface reset-n spi_resetn input 1 if_spi_clk
6766

6867
ad_interface signal trigger input 1 if_pwm
6968

library/util_sigma_delta_spi/util_sigma_delta_spi_hw.tcl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ proc p_elaboration {} {
2727

2828
# clock and reset interface
2929

30-
ad_interface clock clk input 1
31-
ad_interface reset resetn input 1 if_clk
30+
ad_interface clock clk input 1
31+
ad_interface reset-n resetn input 1 if_clk
3232

3333
ad_interface signal spi_active input 1 active
3434
ad_interface signal data_ready output 1 if_pwm

0 commit comments

Comments
 (0)