fix: decouple app lifecycle from sessions autocapture #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polbins
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR decouples the app lifecycle management from the sessions autocapture logic in the Amplitude Kotlin SDK.
- Refactors the AndroidLifecyclePlugin to use a locally scoped configuration by capturing the autocapture set in a dedicated variable.
- Updates all autocapture checks to use the new autocapture variable for improved decoupling.
- Introduces a new test to verify that eventJob is created even when APP_LIFECYCLES is not enabled.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| android/src/test/kotlin/com/amplitude/android/plugins/AndroidLifecyclePluginTest.kt | Adds a new test confirming eventJob creation when APP_LIFECYCLES is disabled. |
| android/src/main/java/com/amplitude/android/plugins/AndroidLifecyclePlugin.kt | Refactors autocapture checks to use a locally stored autocapture variable and removes the redundant global configuration field. |
android/src/main/java/com/amplitude/android/plugins/AndroidLifecyclePlugin.kt
Show resolved
Hide resolved
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
…...v1.21.2-beta.1) (2025-06-03) ### Bug Fixes * decouple app lifecycle from sessions autocapture ([#284](#284)) ([1521eb7](1521eb7))
|
🎉 This PR is included in version 1.21.2-beta.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist