Improve string escaping for HCL interpolation #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised `_escape_interpolated_str` to handle heredoc strings and added more robust escaping for special characters. Added tests and a sample HCL file to validate various unicode and complex string scenarios, ensuring accurate handling and output.
|
Please add |
- Replace `test_unicode_strings.py` with `unicode_strings.json`
|
@kkozik-amplify I've made the requested changes. |
kkozik-amplify
approved these changes
May 5, 2025
kkozik-amplify
added a commit
that referenced
this pull request
May 5, 2025
kkozik-amplify
added a commit
that referenced
this pull request
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised
_escape_interpolated_strto handle heredoc strings and added more robust escaping for special characters.Added tests and a sample HCL file to validate various unicode and complex string scenarios.