Skip to content

revert interpolation grammar to v5.1.1 #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

kkozik-amplify
Copy link
Collaborator

@kkozik-amplify kkozik-amplify commented Mar 24, 2025

  • disable support for interpolations deeper than 2 levels (added this issue to the Limitations section in readme)
  • bring back support for escaped interpolations

Grammar changes allowing parsing of string interpolations deeper than 2 levels (e.g. "${"${"${"a"}"}"}") (#173) broke parsing of escaped interpolations (e.g. "prefix:$${aws:username}-suffix")

This fixes #181

@kkozik-amplify kkozik-amplify force-pushed the fix/interpolation-parsing branch from c6402b6 to db97a0c Compare March 26, 2025 20:51
@kkozik-amplify kkozik-amplify marked this pull request as ready for review March 26, 2025 20:55
@kkozik-amplify kkozik-amplify requested a review from a team as a code owner March 26, 2025 20:55
@kkozik-amplify kkozik-amplify changed the title revert interpolation grammar to v5.1.1 ( disable support for interpolations deeper than 2 levels) revert interpolation grammar to v5.1.1 (disable support for interpolations deeper than 2 levels) Mar 26, 2025
@kkozik-amplify kkozik-amplify merged commit 849c260 into main Mar 27, 2025
10 checks passed
@kkozik-amplify kkozik-amplify deleted the fix/interpolation-parsing branch March 27, 2025 12:16
@kkozik-amplify kkozik-amplify changed the title revert interpolation grammar to v5.1.1 (disable support for interpolations deeper than 2 levels) revert interpolation grammar to v5.1.1 Mar 27, 2025
@kkozik-amplify kkozik-amplify mentioned this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escaping dollar sign causes issues parsing HCL code with 6.0.0
2 participants