Configure Travis to run tests #35
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've ported the CI to Actions and also enhanced it a bit. It's more of a proof of concept than a push to port things to Actions, mainly because I don't know if If Actions is ever considered, however, the implementation is sitting my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, CI appears to just be catching build failures. This PR instructs Travis to run tests as well.
It might be a good idea to also introduce a build matrix with sheep's minimum supported Rust version, current Rust stable, and Rust nightly to catch regressions.
Another thing that could be done is porting to GitHub Actions. Since Travis-CI's Windows support is still beta, this would help sheep run tests on Windows and macOS as well, helping write tests for changes like #33.