A bit better diagnostic on EntityAccessDenied. #300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Currently, all calls to
get_component_storage()
are justunwrap()
ed.This is clearly a temporary code that, unfortunately, is staying with us.
With this change, at least, the user gets a list of types that the calling System needed access to. Currently, it's anybody's guess, and in a deep call trees, it's difficult to see.
How Has This Been Tested?
I removed access to a necessary Component in one of my Systems, and instead of generic unwrap() panic, got a message:
Now I know which Components to add to my System.
Checklist: