Fix http url generation in awsxrayexporter #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisguo
previously approved these changes
Jun 17, 2025
|
Looks like unit tests are failing |
Paramadon
previously approved these changes
Jun 17, 2025
Paramadon
approved these changes
Jun 17, 2025
lisguo
approved these changes
Jun 17, 2025
bjrara
added a commit
to aws-observability/aws-application-signals-test-framework
that referenced
this pull request
Jun 18, 2025
*Issue description:* The E2E test failed after fixing the http url generation in awsxrayexporter. PR: amazon-contributing/opentelemetry-collector-contrib#323 *Description of changes:* Add query parameters into trace assertion. *Rollback procedure:* <Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.> *Ensure you've run the following tests on your changes and include the link below:* To do so, create a `test.yml` file with `name: Test` and workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing. NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the [needs](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idneeds) keyword to run tests in succession. - Run Java EKS on `e2e-playground` in us-east-1 and eu-central-2 - Run Python EKS on `e2e-playground` in us-east-1 and eu-central-2 - Run metric limiter on EKS cluster `e2e-playground` in us-east-1 and eu-central-2 - Run EC2 tests in all regions - Run K8s on a separate K8s cluster (check IAD test account for master node endpoints; these will change as we create and destroy clusters for OS patching) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a request like
http://localhost:8080/apitest?ip=myip&version=testis processed byawsxrayexporter, the generatedhttp.request.urlbecomeshttp://localhost:8080/ip=myip&version=test.Expected:
http://localhost:8080/apitest?ip=myip&version=testLink to tracking issue
Fixes
Integration tests
Testing
Unit test
Documentation