BugFix: Add perCore neuron empty metric as datapoints instead of individual metric object #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
receiver/awscontainerinsightreceiver/internal/neuron/neuron_empty_metric_decorator.go
Outdated
Show resolved
Hide resolved
movence
reviewed
Jun 9, 2025
receiver/awscontainerinsightreceiver/internal/neuron/neuron_empty_metric_decorator.go
Show resolved
Hide resolved
receiver/awscontainerinsightreceiver/internal/neuron/neuron_empty_metric_decorator.go
Show resolved
Hide resolved
movence
previously approved these changes
Jun 10, 2025
aditya-purang
previously approved these changes
Jun 10, 2025
sky333999
previously approved these changes
Jun 10, 2025
spanaik
dismissed stale reviews from sky333999, aditya-purang, and movence
via
aaf7cb9
aditya-purang
approved these changes
Jun 13, 2025
sky333999
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix: The current empty metric decorator adds per core metrics as individual metric in the metrics slice, this is not the correct behavior from the neuron monitor service endpoint, each core is a data-point in the metric object.
This was discovered during another bug fix in the
gpuattributesprocessor for aggregating metrics across neuron cores across run time's.Testing
Unit tests added to cover the behavior.