Use k8s secret file for bearer token to handle key rotations #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okankoAMZ
reviewed
Mar 18, 2025
receiver/awscontainerinsightreceiver/internal/k8sapiserver/prometheus_scraper.go
Show resolved
Hide resolved
sky333999
previously approved these changes
Mar 18, 2025
okankoAMZ
approved these changes
Mar 19, 2025
sky333999
approved these changes
Mar 19, 2025
sky333999
merged commit 62fc4da
into
amazon-contributing:aws-cwa-dev
135 of 147 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a Kubernetes secret file for the bearer token when accessing the apiserver prometheus endpoint to properly handle key rotations. This aligns with the recent update made to the Kueue receiver, ensuring consistency in authentication management. #285
Testing
Deployed the changes to a testing cluster to verify for apiserver metric
apiserver_request_total