add toggle to enable/disable logging #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenlep-amzn
reviewed
Jun 5, 2025
There was a problem hiding this comment.
LGTM overall, will approve once build is passing
> Task :app:compileReleaseKotlin FAILED
e: file:///home/runner/work/amazon-connect-chat-android/amazon-connect-chat-android/app/src/main/java/com/amazon/connect/chat/androidchatexample/utils/CustomLogger.kt:20:1 Class 'CustomLogger' is not abstract and does not implement abstract member public abstract fun setLoggingEnabled(enabled: Boolean): Unit defined in com.amazon.connect.chat.sdk.utils.logger.ChatSDKLogger
| @@ -120,7 +118,7 @@ class WebSocketManagerImpl @Inject constructor( | |||
| reestablishConnectionIfChatActive() | |||
| } else { | |||
| isConnectedToNetwork = false | |||
| Log.d("WebSocketManager", "Network connection lost") | |||
There was a problem hiding this comment.
nit: did we intend to use logger.debug() in place of Log.d here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Description:
Allowing logger to be enabled/disabled
Functional backward compatibility:
Does this change introduce backwards incompatible changes? [NO]
Does this change introduce any new dependency? [NO]
Testing:
Have you tested the changes with a sample UI (e.g. Android Mobile Chat Example)? yes
List manual testing steps: