Add Unit Tests to network and provider functions #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mliao95
reviewed
May 12, 2025
| @ExperimentalCoroutinesApi | ||
| @RunWith(RobolectricTestRunner::class) | ||
| @Config(manifest = Config.NONE) | ||
| class WebSocketManagerTest { |
There was a problem hiding this comment.
I don't think we're covering many of the core cases in this test file. We should really be testing connection/disconnection/reconnection logic here as well as parseTranscriptItemFromJson.
I would reference a file like ChatServiceImplTest.kt for how we want to implement unit tests.
haomingli2020
approved these changes
May 12, 2025
mliao95
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing test coverage for the package.
As part of this change we are adding Unit Tests to network and provider functions.