Fixing getTranscript loop on reconnection flow #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mliao95
requested review from
jagadeeshaby,
agarwhi,
haomingli2020 and
spenlep-amzn
agarwhi
reviewed
Apr 11, 2025
| private suspend fun fetchTranscriptWith(startPosition: StartPosition?) { | ||
| getTranscript(startPosition = startPosition, | ||
| scanDirection = ScanDirection.FORWARD, | ||
| sortKey = SortKey.ASCENDING, | ||
| maxResults = 30, | ||
| maxResults = 100, |
There was a problem hiding this comment.
what made us to increase the maxResults ? will not increase the response object size & latency ?
There was a problem hiding this comment.
It will only return a larger object/latency if there are more messages, and if there are more messages, it would be better to have one API call vs. two smaller API calls.
Since this logic is to fetch messages that are missing during disconnection, we wouldn't want to retrieve only part of the missing messages.
spenlep-amzn
previously approved these changes
Apr 11, 2025
spenlep-amzn
previously approved these changes
Apr 11, 2025
haomingli2020
previously approved these changes
Apr 11, 2025
agarwhi
previously approved these changes
Apr 11, 2025
mliao95
dismissed stale reviews from agarwhi, haomingli2020, and spenlep-amzn
via
cde4e15
haomingli2020
approved these changes
Apr 11, 2025
saipreetham16
approved these changes
Apr 11, 2025
spenlep-amzn
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Description:
What are the changes? Why are we making them?
This PR fixes an unexpected getTranscript loop regarding the re-connection flow. The issue stems from an unexpected behavior where calling getTranscript in the forward direction will always return the last item and a nextToken even if there are no more messages.
This PR fixes this issue by changing the conditional to add another check to see whether the last returned message is already within the internal transcript. If it is, we already know that we have fetched all available messages.
Functional backward compatibility:
Does this change introduce backwards incompatible changes? [YES/NO]
NO
Does this change introduce any new dependency? [YES/NO]
NO
Testing:
Is the code unit tested?
YES
Have you tested the changes with a sample UI (e.g. Android Mobile Chat Example)?
List manual testing steps:
Here are a list of manual test cases to run through: