Skip to content

Adding additional events to ContentType + Add CODEOWNERS file #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

mliao95
Copy link
Contributor

@mliao95 mliao95 commented Apr 2, 2025

Issue Number:

Description:

What are the changes? Why are we making them?

This PR updates the list of chat events to cover additional scenarios such as authentication, idle, transfers and chat re-hydration.

This PR also adds a CODEOWNERS file so that reviewers are auto-assigned upon PR creation.


Functional backward compatibility:

Does this change introduce backwards incompatible changes? [YES/NO]

NO

Does this change introduce any new dependency? [YES/NO]

NO


Testing:

Is the code unit tested?

NA

Have you tested the changes with a sample UI (e.g. Android Mobile Chat Example)?

NA

List manual testing steps:

  • Add Steps below:

Here are a list of manual test cases to run through:

  • Initiating chat and connecting with an agent
  • Retrieving transcript
  • Disconnecting from chat
  • Sending a message to the agent
    • See typing bubbles on agent side
    • See read/delivered receipt on client side
    • Receiving a message from the agent
    • See typing bubbles on client side
    • See read/delivered receipt on agent side
    • Sending an attachment to the agent (try .txt, .pdf, .jpg)
    • Preview the attachment on click
    • Receiving an attachment from the agent
    • Preview the attachment on click
  • Close the application (Without ending chat) → open app again → Start chat → Should Retrieve transcript from a previous chat session

@mliao95 mliao95 requested a review from Copilot April 2, 2025 21:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the ContentType enum to support additional chat-related events such as authentication events, participant state changes, transfer events, and chat rehydration.

  • Added several new ContentType enum values to cover the expanded event list.
  • Updated the enum formatting from a semicolon after the original list to a comma-separated list followed by a semicolon on the final entry.
Comments suppressed due to low confidence (1)

chat-sdk/src/main/java/com/amazon/connect/chat/sdk/model/ContentType.kt:36

  • [nitpick] Consider adding unit tests to validate the mapping of ContentType enum values, particularly for the newly added events.
companion object {

Adding CODEOWNERS file
@mliao95 mliao95 changed the title Adding additional events to ContentType Adding additional events to ContentType + Add CODEOWNERS file Apr 2, 2025
@mliao95 mliao95 requested a review from agarwhi April 8, 2025 18:27
@mliao95 mliao95 merged commit bbe13c4 into main Apr 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants