Fixing ChatSession.reset #52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Description:
What are the changes? Why are we making them?
Moving
cleanup()
to the main thread inChatSession
. Sincecleanup()
triggers theonChatSessionStateChanged
event handler, customers that hook on to that event and callsetValue
will need that executed on the main thread.The previous code was grouping
cleanup()
with the asynchronouschatService.reset
call which forcedcleanup
to run on the background thread, where users cannot hook onto the event to modify values usingsetValue
.Functional backward compatibility:
Does this change introduce backwards incompatible changes? [YES/NO]
NO
Does this change introduce any new dependency? [YES/NO]
NO
Testing:
Is the code unit tested?
Have you tested the changes with a sample UI (e.g. Android Mobile Chat Example)?
List manual testing steps:
Here are a list of manual test cases to run through: