Skip to content

Fixing ChatSession.reset #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2025
Merged

Fixing ChatSession.reset #52

merged 2 commits into from
Mar 8, 2025

Conversation

mliao95
Copy link
Contributor

@mliao95 mliao95 commented Mar 7, 2025

Issue Number:

Description:

What are the changes? Why are we making them?

Moving cleanup() to the main thread in ChatSession. Since cleanup() triggers the onChatSessionStateChanged event handler, customers that hook on to that event and call setValue will need that executed on the main thread.

The previous code was grouping cleanup() with the asynchronous chatService.reset call which forced cleanup to run on the background thread, where users cannot hook onto the event to modify values using setValue.


Functional backward compatibility:

Does this change introduce backwards incompatible changes? [YES/NO]

NO

Does this change introduce any new dependency? [YES/NO]

NO


Testing:

Is the code unit tested?

Have you tested the changes with a sample UI (e.g. Android Mobile Chat Example)?

List manual testing steps:

  • Add Steps below:

Here are a list of manual test cases to run through:

  • Initiating chat and connecting with an agent
  • Retrieving transcript
  • Disconnecting from chat
  • Sending a message to the agent
    • See typing bubbles on agent side
    • See read/delivered receipt on client side
    • Receiving a message from the agent
    • See typing bubbles on client side
    • See read/delivered receipt on agent side
    • Sending an attachment to the agent (try .txt, .pdf, .jpg)
    • Preview the attachment on click
    • Receiving an attachment from the agent
    • Preview the attachment on click
  • Close the application (Without ending chat) → open app again → Start chat → Should Retrieve transcript from a previous chat session

doreechi
doreechi previously approved these changes Mar 8, 2025
agarwhi
agarwhi previously approved these changes Mar 8, 2025
@mliao95 mliao95 dismissed stale reviews from agarwhi and doreechi via efcdeb4 March 8, 2025 00:45
@mliao95 mliao95 merged commit b42bc53 into main Mar 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants