Skip to content

Exposing ConnectionDetailsProvider in ChatSession #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

haomingli2020
Copy link
Contributor

Issue Number:
N/A

Description:

What are the changes? Why are we making them?
Exposing ConnectionDetailsProvider in ChatSession


Functional backward compatibility:

Does this change introduce backwards incompatible changes? [NO]

Does this change introduce any new dependency? [NO]


Testing:

Is the code unit tested?
Yes

Have you tested the changes with a sample UI (e.g. Android Mobile Chat Example)?
Yes

List manual testing steps:

  • Add Steps below:
    Manually tested calling chatSession.getConnectionDetailsProvider().getConnectionDetails() and verified the connection token was received. Also verified a new connection token is received after background/foreground events.

Here are a list of manual test cases to run through:

  • Initiating chat and connecting with an agent
  • Retrieving transcript
  • Disconnecting from chat
  • Sending a message to the agent
    • See typing bubbles on agent side
    • See read/delivered receipt on client side
    • Receiving a message from the agent
    • See typing bubbles on client side
    • See read/delivered receipt on agent side
    • Sending an attachment to the agent (try .txt, .pdf, .jpg)
    • Preview the attachment on click
    • Receiving an attachment from the agent
    • Preview the attachment on click
  • Close the application (Without ending chat) → open app again → Start chat → Should Retrieve transcript from a previous chat session

@mliao95
Copy link
Contributor

mliao95 commented Feb 27, 2025

Could you also update the README?

@haomingli2020 haomingli2020 force-pushed the haominli/expose-connection-details branch from ab80958 to 9cfa402 Compare February 27, 2025 22:27
mliao95
mliao95 previously approved these changes Feb 27, 2025
@haomingli2020 haomingli2020 force-pushed the haominli/expose-connection-details branch from 2f85093 to 82f632e Compare February 27, 2025 22:58
@mliao95 mliao95 self-requested a review February 27, 2025 23:02
@haomingli2020 haomingli2020 merged commit 1ca7d8d into main Feb 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants