Improved fallback mechanism when user is not using hilt/dagger #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mliao95
reviewed
Jan 28, 2025
| true | ||
| } catch (e: ClassNotFoundException) { | ||
| SDKLogger.logger.logDebug {"Hilt is not available"} | ||
| SDKLogger.logger.logError { "Hilt is not available: ${e.message}" } |
There was a problem hiding this comment.
Do we want to log this as an error or as a debug? I feel like it is almost expected that users will fall into this path and we shouldn't emit errors for expected workflows.
There was a problem hiding this comment.
Agree. will update it
mrajatttt
force-pushed
the
rajatttt/better-hilt-support
branch
from
ea85776 to
ef5ccdf
Compare
mliao95
previously approved these changes
Jan 29, 2025
agarwhi
previously approved these changes
Jan 29, 2025
mliao95
approved these changes
Feb 3, 2025
agarwhi
reviewed
Feb 3, 2025
| false | ||
| } catch (e: Exception) { | ||
| // Catch any unexpected issues during class detection | ||
| SDKLogger.logger.logDebug { "Error while checking Hilt availability: ${e.message}" } |
| } | ||
| } catch (e: Exception) { | ||
| // Handle unexpected errors during initialization | ||
| SDKLogger.logger.logDebug { "Error initializing ChatSession: ${e.message}" } |
There was a problem hiding this comment.
Yes we aim to print it as a debug which won't interrupt the flow
agarwhi
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Description:
What are the changes? Why are we making them?
Functional backward compatibility:
Does this change introduce backwards incompatible changes? [YES/NO]
Does this change introduce any new dependency? [YES/NO]
Testing:
Is the code unit tested?
Have you tested the changes with a sample UI (e.g. Android Mobile Chat Example)?
List manual testing steps:
Here are a list of manual test cases to run through: