Skip to content

Modified logic to handle previous chat ended events #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

mrajatttt
Copy link
Contributor

Issue Number:

Description:

What are the changes? Why are we making them?

  • Removed time based event comparison, Now we will attach isFromPastSession to getTranscript result items to track of past items and take action based on this flag. This reduces our dependency on tracking time and managing it!
  • isFromPastSession will be marked as true for all getTranscript items and while fetching the object, default is set to false

Functional backward compatibility:

Does this change introduce backwards incompatible changes? [YES/NO]

Does this change introduce any new dependency? [YES/NO]


Testing:

Is the code unit tested?

Have you tested the changes with a sample UI (e.g. Android Mobile Chat Example)?

List manual testing steps:

  • Add Steps below:

Here are a list of manual test cases to run through:

  • Initiating chat and connecting with an agent
  • Retrieving transcript
  • Disconnecting from chat
  • Sending a message to the agent
    • See typing bubbles on agent side
    • See read/delivered receipt on client side
    • Receiving a message from the agent
    • See typing bubbles on client side
    • See read/delivered receipt on agent side
    • Sending an attachment to the agent (try .txt, .pdf, .jpg)
    • Preview the attachment on click
    • Receiving an attachment from the agent
    • Preview the attachment on click
  • Close the application (Without ending chat) → open app again → Start chat → Should Retrieve transcript from a previous chat session

@mrajatttt mrajatttt requested review from agarwhi and mliao95 January 23, 2025 00:12
@mrajatttt mrajatttt merged commit 76915ec into main Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants