Fixes the bug where chat was getting stuck while retrieving previous session's transcript #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Description:
What are the changes? Why are we making them?
The issue arises when users attempt to load the transcript from a previous session using persistent chat. While we were processing the response in Android, we had added a “closing” WebSocket and sent a “chat has ended” callback to the customer after parsing an “chat ended” event that we received in the transcript.
This fix prevents the action from being taken at the parsing level and instead sends the “chat has ended” callback to the customer once they disconnect and close the WebSocket simultaneously.
Functional backward compatibility:
Does this change introduce backwards incompatible changes? [YES/NO]
Does this change introduce any new dependency? [YES/NO]
Testing:
Is the code unit tested?
Have you tested the changes with a sample UI (e.g. Android Mobile Chat Example)?
List manual testing steps:
Here are a list of manual test cases to run through: