Skip to content

Fixes the bug where chat was getting stuck while retrieving previous session's transcript #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

mrajatttt
Copy link
Contributor

Issue Number:

Description:

What are the changes? Why are we making them?

The issue arises when users attempt to load the transcript from a previous session using persistent chat. While we were processing the response in Android, we had added a “closing” WebSocket and sent a “chat has ended” callback to the customer after parsing an “chat ended” event that we received in the transcript.

This fix prevents the action from being taken at the parsing level and instead sends the “chat has ended” callback to the customer once they disconnect and close the WebSocket simultaneously.


Functional backward compatibility:

Does this change introduce backwards incompatible changes? [YES/NO]

Does this change introduce any new dependency? [YES/NO]


Testing:

Is the code unit tested?

Have you tested the changes with a sample UI (e.g. Android Mobile Chat Example)?

List manual testing steps:

  • Add Steps below:

Here are a list of manual test cases to run through:

  • Initiating chat and connecting with an agent
  • Retrieving transcript
  • Disconnecting from chat
  • Sending a message to the agent
    • See typing bubbles on agent side
    • See read/delivered receipt on client side
    • Receiving a message from the agent
    • See typing bubbles on client side
    • See read/delivered receipt on agent side
    • Sending an attachment to the agent (try .txt, .pdf, .jpg)
    • Preview the attachment on click
    • Receiving an attachment from the agent
    • Preview the attachment on click
  • Close the application (Without ending chat) → open app again → Start chat → Should Retrieve transcript from a previous chat session

@mliao95 mliao95 self-requested a review December 19, 2024 04:38
@mrajatttt mrajatttt merged commit d900251 into main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants