Skip to content

Fix: Only set time-based features to NaN for rows with missing time index (closes #2700)Fix: Only set time-based features to NaN for rows with missing time i… #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

realranjan
Copy link

 ## What does this PR do?
 - Fixes [Issue #2700](https://github.com/alteryx/featuretools/issues/2700): Previously, if any row in a DataFrame had a missing time index, all features for that row became NaN.
 - Now, only time-based features are set to NaN for rows with missing time index; non-time-based features are still computed.
 - Adds/updates tests (including `test_missing_time_index_rows`) to verify correct behavior.

 ## How was this tested?
 - All tests pass locally.
 - The new test ensures only time-based features are NaN for missing time index rows, while non-time-based features are always computed.

 ## Checklist
 - [x] Fix implemented
 - [x] Tests updated/added
 - [x] All tests passing
 - [x] Linked to #2700

 Closes #2700

…ndex (closes alteryx#2700) - Non-time-based features are now computed for all rows, even if time index is missing. - Time-based features are NaN only for rows with missing time index. - Added/updated tests to verify correct behavior.
@CLAassistant
Copy link

CLAassistant commented Jun 7, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants