[SPIKE] Restyle navigation to blend with header and masthead #4748
+39
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify project configuration. |
querkmachine
force-pushed
the
inverse-service-navigation
branch
from
4aa3a7a to
89076c8
Compare
querkmachine
force-pushed
the
inverse-service-navigation
branch
from
89076c8 to
3188223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restyles the navigation on the homepage to blend in with the redesigned header and masthead. Part of #4734.
Changes
isHomepagefunction to determine if the current page is the site homepage.Thoughts
The
isHomepagefunction uses similar logic that breadcrumbs were previously using, that is, expecting an empty string for thepermalinkcontext item (which, as far as I know, only the homepage has). There is probably a nicer way of doing this, like reading the path of the underlying file, but I'm not sure what metadata is available in the page context.