Skip to content

Getting this built for Fedora 41 #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Getting this built for Fedora 41 #1671

wants to merge 3 commits into from

Conversation

@gerstrong
Copy link

No description provided.

nshmyrev
nshmyrev reviewed Nov 30, 2024
View reviewed changes
src/recognizer.cc

clat = decoder_->GetLattice(decoder_->NumFramesInLattice(), false);
if (model_->winfo_) {
WordAlignLatticePartial(clat, *model_->trans_model_, *model_->winfo_, 0, &aligned_lat);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, why do you change this? It is critical for functionality. Your kaldi changes in kaldi-asr/kaldi#4963 are also breaking things since we use different openfst version (our own branch) from Kaldi.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it did not compile: Error: ‘WordAlignLatticePartial’ was not declared in this scope

So how would fix this then?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me look at the test...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to merge this patch into main kaldi. And probably other changes from our vosk branch

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphacep/kaldi@98155d8

@nshmyrev
Copy link
Collaborator

Thanks for your submission between!

@gerstrong
Copy link
Author

Thanks for your submission between!

Thanks, that was fast. :-)

The failed test seems to be some crash. For some reason with CMake the testlattice-utils-test passes. Maybe some CICD Process acting strange?

Running determinize-lattice-test ... 0s... SUCCESS determinize-lattice-test
/bin/bash: line 2: 30861 Aborted                 (core dumped) ./$x > $x.testlog 2>&1
Running lattice-utils-test ... 0s... FAIL lattice-utils-test

@nshmyrev
Copy link
Collaborator

nshmyrev commented Dec 2, 2024

Sorry, not sure about it, I never use cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nshmyrev nshmyrev nshmyrev left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gerstrong @nshmyrev