-
Notifications
You must be signed in to change notification settings - Fork 27
Add Dataclass component #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bterlson
merged 15 commits into
alloy-framework:main
from
pinterest:feature/dataclass-python
Oct 30, 2025
Merged
Add Dataclass component #325
bterlson
merged 15 commits into
alloy-framework:main
from
pinterest:feature/dataclass-python
Oct 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub does not run workflows by default in forked repositories; indeed, we do not want to run the workflows in the parent repo (which include things like publishing artifacts). Instead, we create our own version of the `CI` workflow and will manually disable all the others (so those files can still be updated without merge conflict).
Fix sets with mapJoin (alloy-framework#199). Sets were just never supported in mapJoin even though `For` said they were. Also fixes an issue where immediately recursive effects wouldn't run.
Add support for floating points ending in .0 in Python implementation. The current behavior just converts them into an integer. --------- Co-authored-by: Steve Rice <steve@steverice.org>
Add an extra line after the ClassDoc, as described by [PEP 257](https://peps.python.org/pep-0257/#multi-line-docstrings): > Insert a blank line after all docstrings (one-line or multi-line) that document a class – generally speaking, the class’s methods are separated from each other by a single blank line, and the docstring needs to be offset from the first method by a blank line.
|
All changed packages have been documented.
|
commit: |
bterlson
reviewed
Oct 24, 2025
bterlson
reviewed
Oct 24, 2025
bterlson
reviewed
Oct 24, 2025
bterlson
reviewed
Oct 24, 2025
bterlson
reviewed
Oct 24, 2025
bterlson
reviewed
Oct 24, 2025
bterlson
reviewed
Oct 24, 2025
bterlson
reviewed
Oct 24, 2025
bterlson
reviewed
Oct 24, 2025
bterlson
reviewed
Oct 24, 2025
bterlson
reviewed
Oct 24, 2025
bterlson
reviewed
Oct 24, 2025
bterlson
reviewed
Oct 24, 2025
bterlson
reviewed
Oct 29, 2025
bterlson
reviewed
Oct 29, 2025
bterlson
reviewed
Oct 29, 2025
bterlson
reviewed
Oct 29, 2025
bterlson
reviewed
Oct 29, 2025
bterlson
reviewed
Oct 29, 2025
bterlson
reviewed
Oct 29, 2025
bterlson
reviewed
Oct 29, 2025
bterlson
reviewed
Oct 29, 2025
bterlson
reviewed
Oct 29, 2025
* Add Dataclass component * format * Accounting for feedback * Wrap childrenArray in compute() * Account for feedback * Fix * Fix * Fix * Fix
44f7a7b to
a502ff9
Compare
bterlson
reviewed
Oct 29, 2025
bterlson
approved these changes
Oct 29, 2025
bterlson
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Dataclass component to the Python implementation. Used the ClassComponent, just applying some specific behavior on top of it.