Add occupiedSince property to ElectricityStationOccupancyResponse and remove attendees from ElectricityStationsOccupancyResponse #6
Conversation
The `occupiedSince` property was added to the example, but not to the properties in the specification. This is now rectified. Signed-off-by: Johan Vergeer <johan.vergeer@alliander.com>
…chema The `attendees` are not returned by the `occupancy` endpoint, which was only mentioned in the endpoint description. By changing the actual schema it is more clear and the schema can be used by generators. Signed-off-by: Johan Vergeer <johan.vergeer@alliander.com>
johanvergeer
changed the title
|
I dont think we want to remove the attendees from the ElectricityStationsOccupancyResponse? |
|
@brense The attendees are not sent when all stations are sent as far as I know. Or has that been changed recently? |
|
As far as I know the architecture board agreed with having the same type of response for a single station or the list of stations. I also spoke with Danny this morning and that is their preferred option as well. Otherwise they have to perform n+1 requests when trying to do a full sync, where n is the number of stations they've provided to LSIS. |
|
In that case I will revert the change. Does that also mean the attendees will be sent in that response. When that is the case I will remove the |
…ponse` schema" This reverts commit 411d12b.
Signed-off-by: Johan Vergeer <johan.vergeer@alliander.com>
|
@brense I made the changes we discussed. Can you have another look? |
occupiedSinceproperty was added to the example, but not to the properties in the specification. This is now rectified.attendeesproperty is now removed from theElectricityStationsOccupancyResponseinstead of mentioning it in theoccupancydescription.