Skip to content

Updated to use topic names for presence queue and added region property to externalIds #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

brense
Copy link
Contributor

@brense brense commented Feb 13, 2025

No description provided.

johanvergeer
johanvergeer previously approved these changes Feb 24, 2025
…ternal-ids

Signed-off-by: Rense Bakker <b.rense@gmail.com>
@nickhuegen
Copy link
Collaborator

After I get permissions, I will approve.

@brense brense marked this pull request as ready for review March 13, 2025 18:14
@johanvergeer
Copy link
Collaborator

@brense Vanuit compliancy willen ze een Signed-off-by: header zien. Voor deze PR kunnen we dat nog wel omzeilen, maar in de toekomst wordt dit wel afgedwongen. De meeste code editors/IDE's hebben ook een instelling waardoor deze header automatisch aan de commit wordt toegevoegd.

@johanvergeer johanvergeer merged commit 4d6fa7c into alliander-opensource:main Mar 14, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants