feat: support IMDS v2 default for ecs ram role #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yndu13
force-pushed
the
disableIMDSv1
branch
from
35aafb6 to
5b9d79d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
==========================================
- Coverage 98.93% 98.93% -0.01%
==========================================
Files 30 30
Lines 2064 2061 -3
==========================================
- Hits 2042 2039 -3
Misses 12 12
Partials 10 10 ☔ View full report in Codecov by Sentry. |
yndu13
force-pushed
the
disableIMDSv1
branch
2 times, most recently
from
d3430cd to
5de6c12
Compare
JacksonTian
reviewed
Sep 11, 2024
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if metadataToken != "" { |
There was a problem hiding this comment.
getMetadataToken 应该抛错吧，如果为空字符串的话
There was a problem hiding this comment.
getMetadataToken中，如果disableIMDSv1开启了，才会抛错，否则忽略报错走v1
|
覆盖率跌了。 |
yndu13
force-pushed
the
disableIMDSv1
branch
from
5de6c12 to
4b03f70
Compare
JacksonTian
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You need to complete