Skip to content

Conversation

xanth
Copy link

@xanth xanth commented Aug 30, 2025

Description

Unfortunately Husky can't find .net9 inside of a Nix flake/shell when .net 10 is present, so I propose a beta release in preparation of the .net 10 release in November.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • I did test corresponding changes on Windows
  • I did test corresponding changes on Linux
  • I did test corresponding changes on Mac

Copy link

what-the-diff bot commented Aug 30, 2025

PR Summary

  • Included Net 10.0 as one of Target Frameworks
    The PR updates the software's target frameworks to include version 10.0 of .NET, which means the application will be compatible and capable of running on the latest version of .NET, improving performance and security.

  • New Property Group for Net 10.0
    In addition to the inclusion of the new version, a new Property Group was added specifying a Configuration Version of '10.0.0-preview.7.25380.108'. This assists in defining particular properties to .NET 10.0, optimizing application settings for this specific version.

@xanth
Copy link
Author

xanth commented Sep 2, 2025

Looking for review @alirezanet

Copy link
Owner

@alirezanet alirezanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 💐

@alirezanet
Copy link
Owner

alirezanet commented Sep 3, 2025

Apparently we need to also update the tests to support .Net 10, although not sure why it is complaining about net9. need to investigate further

@xanth
Copy link
Author

xanth commented Sep 14, 2025

Sorry I meant to come back and resolve this, but on reflection perhaps this is the wrong approach long term as this'll keep happening and requires more maintenance than it has to. Ether this should target net standard, which having attempted retargeting I don't think its worth the work, or doing something like this and producing self contained versions at least as an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants