Skip to content

[atlas-update] Avoid Zip Slip Vulnerability #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[atlas-update] Avoid Zip Slip Vulnerability #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions atlas-update/src/main/java/com/taobao/atlas/update/util/ZipUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,18 @@ public static void unzip(String zipFilename, String outputDirectory)
dirName = dirName.substring(0, dirName.length() - 1);
File f = new File(outFile.getPath() + File.separator + dirName);
f.mkdirs();
if (!f.getCanonicalPath().startsWith(outputDirectory)) {
System.out.println("Zip Slip exploit detected. Skipping entry " + dirName);
continue;
}
} else {
String strFilePath = outFile.getPath() + File.separator
+ zipEntry.getName();
File f = new File(strFilePath);
if (!f.getCanonicalPath().startsWith(outputDirectory)) {
System.out.println("Zip Slip exploit detected. Skipping entry " + zipEntry.getName());
continue;
}

// 判断文件不存在的话，就创建该文件所在文件夹的目录
if (!f.exists()) {
Expand Down