Skip to content

Conversation

@gaoyf
Copy link
Contributor

@gaoyf gaoyf commented Oct 16, 2025

Describe what this PR does / why we need it

当同时配置了具体规则和正则规则时,应该优先使用具体规则,而不是同时使用两种规则。

Does this pull request fix one issue?

Fixes #3564

Describe how you did it

当具体规则存在时,不再匹配正则规则。

Describe how to verify it

测试

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2025

CLA assistant check
All committers have signed the CLA.

@LearningGp LearningGp added to-review To review kind/feature Category issues or prs related to feature request. labels Oct 16, 2025
@LearningGp LearningGp moved this to In progress in Sentinel Oct 16, 2025
@LearningGp
Copy link
Collaborator

The code itself looks fine. However, since this feature introduces a breaking change to the default behavior, it would be best to include a feature switch for it in the current release—disabled by default. We’ll highlight this in the release notes and plan to either enable it by default or remove the switch entirely in a future version.

@LearningGp LearningGp added the wait-for-response PRs that require further response label Oct 22, 2025
@LearningGp LearningGp moved this from In progress to In review in Sentinel Oct 22, 2025
…match, default: false, keeps backward compatibility.
@gaoyf
Copy link
Contributor Author

gaoyf commented Oct 23, 2025

The code itself looks fine. However, since this feature introduces a breaking change to the default behavior, it would be best to include a feature switch for it in the current release—disabled by default. We’ll highlight this in the release notes and plan to either enable it by default or remove the switch entirely in a future version.

Makes sense — I’ve added an optional switch to handle this case as suggested.

Copy link
Collaborator

@LearningGp LearningGp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LearningGp
Copy link
Collaborator

Thanks for contributing!

@LearningGp LearningGp merged commit e60f0d0 into alibaba:1.8 Nov 3, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Sentinel Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Category issues or prs related to feature request. to-review To review wait-for-response PRs that require further response

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

具体规则和正则规则合并疑问

3 participants