Skip to content

chore: more demonstrative examples #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 10, 2025
Merged

chore: more demonstrative examples #14

merged 5 commits into from
May 10, 2025

Conversation

joe-p
Copy link
Contributor

@joe-p joe-p commented Nov 7, 2024

Proposed Changes

  • Makes the examples a bit more realistic and demonstrative of the various ways the subscriber could be used

@joe-p joe-p marked this pull request as ready for review November 19, 2024 18:37
@joe-p joe-p requested a review from SilentRhetoric November 19, 2024 18:38
@joe-p
Copy link
Contributor Author

joe-p commented Nov 19, 2024

@SilentRhetoric I have added you as a reviewer of this PR. The intention is that devrel can use these examples to get an initial understanding of how the library is used asynchronously. Then we can follow-up with a meeting with any questions/feedback if needed.

Copy link

@SilentRhetoric SilentRhetoric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these examples--very helpful. Just flagged a few nits.

@joe-p joe-p requested a review from SilentRhetoric May 7, 2025 13:58
@joe-p
Copy link
Contributor Author

joe-p commented May 9, 2025

@lempira Can you try running poetry run pre-commit run --all-files locally? It's passing for me locally but not on CI for some reason.

@lempira
Copy link
Contributor

lempira commented May 9, 2025

@lempira Can you try running poetry run pre-commit run --all-files locally? It's passing for me locally but not on CI for some reason.

There were some ruff files that were failing. I think the ruff version in the ci was different than the one the pyproject. (not sure why, tho) I updated ruff to the latest in a previous commit before the HEAD of this branch. I rebased main and then precommited all files.

@joe-p joe-p requested a review from lempira May 9, 2025 22:02
@joe-p joe-p merged commit f90fabb into main May 10, 2025
3 checks passed
@joe-p joe-p deleted the chore/examples branch May 13, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants