fix(codesandbox-javascript-client) app.js to function with js client v5 #6630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were breaking changes with the upgrade to v5 causing codeSandbox to not work correctly Made the required changes to client etc so it now functions
palacejackson
changed the title
palacejackson
changed the title
|
thanks for your PR, but it should be made to the source: https://github.com/algolia/instantsearch/tree/master/packages/create-instantsearch-app/src/templates. It seems all templates may still use v4 imports and dependencies. It's probably interesting to update them all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were breaking changes with the upgrade to v5 causing codeSandbox to not work correctly
Made the required changes to client etc so it now functions
Summary
Result