Skip to content

Dev/misc #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2023
Merged

Dev/misc #96

merged 3 commits into from
Mar 22, 2023

Conversation

xnorpx
Copy link
Collaborator

@xnorpx xnorpx commented Mar 21, 2023

misc small things

  1. add a comment how to override the vendored openssl flag for people that want to use system installed openssl (this maybe should be a feature flag instead?)
  2. change a variable name to be channel instead of media in data channel example in docs
  3. fix misc clippy warnings that showed up in our environment.

algesten
algesten reviewed Mar 21, 2023
View reviewed changes
Copy link
Owner

@algesten algesten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most things OK. Two things I think need changing.

algesten
algesten approved these changes Mar 21, 2023
View reviewed changes
Copy link
Owner

@algesten algesten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@algesten algesten merged commit c932563 into algesten:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algesten algesten algesten approved these changes

@k0nserv k0nserv k0nserv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xnorpx @algesten @k0nserv