Update HTML report generation #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated to latest Bootstrap version - Removed superfluous dependencies - Enhanced graph navigation (especially for large clusters) - Placed legend within a popover (hidden by default) Signed-off-by: Dominik Prodinger <35099504+prodingerd@users.noreply.github.com>
|
Hello @gadinaor-r7, can you please add some feedback, thank you. |
|
@prodingerd - thanks for the PR - I'll block some time as soon as I can to review and look into this PR |
|
Hi @gadinaor-r7, I was wondering if you found some time to look at the PR? 😁 |
|
@prdngr - I did start to review and tested it actually a while back, and ended up getting pulled to something else before sharing feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR fixes some usability issues I encountered with the HTML report generated by the
vizcommand. Here's a list of things I addressed:Let me know what you think