feat: adds webauthn client tests #1563
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
🌿 Documentation Preview
|
| // connect session key | ||
| let sessionKeyClient = await createModularAccountV2Client({ | ||
| chain: instance.chain, | ||
| signer: webAuthnSigningMethodsSessionKey, |
There was a problem hiding this comment.
should be passing in instance of SmartAccountSigner here
| name: "backUp", | ||
| }); | ||
|
|
||
| const webAuthnSigningMethods: SmartAccountSigner = new WebAuthnSigningMethods( |
There was a problem hiding this comment.
I think I am mistakenly treating this like an instance of SmartAccountSigner when this is a standalone collection of webauthn signing methods, so it would get access to the WebAuthnCredentials via the account
There was a problem hiding this comment.
I left comments in the spec about this. It's not a smart account signer, it's what's used to create the various sign* methods on the account itself. the account doesn't take a signer as input anymore, and just takes in the credential
…al on try-webauthn.appspot.com
linnall
force-pushed
the
linna/webauth-tests
branch
from
36cd477 to
7549458
Compare
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces a new
webauthnGasEstimatormiddleware for estimating gas usage in user operations with Modular Account V2 WebAuthn accounts. It enhances the account creation process and adds support for accounts without a signer.Detailed summary
webauthnGasEstimatortoindex.ts.webauthnGasEstimatorinwebauthnGasEstimator.ts.createModularAccountV2Clientto support WebAuthn mode.CreateModularAccountV2ParamsNoSignertype.createMAv2Baseto handle WebAuthn parameters.webauthnSigningFunctionsfor signing operations insigner.ts.