Skip to content

66 improved contraction pressure #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 5, 2025

Conversation

MaxBalmus
Copy link
Collaborator

A new model proposed as an alternative to KorakianitisMixedModel called KorakianitisMixedModel_PP (preserved pressure). It uses a slightly modified chamber model HC_mixed_elastance_pp, which modifies the total pressure from the form:

p(t,v) = [1-a(t)] * p_pas(v) + a(t) * p_act(v)

to:

p(t,v) = p_pas(v) + a(t) * p_act(v)

This new format prevents the pressure during contraction from being lower than the passive equivalent.

@MaxBalmus MaxBalmus requested a review from LevanBokeria June 4, 2025 10:37
@MaxBalmus MaxBalmus added the enhancement New feature or request label Jun 4, 2025
@MaxBalmus MaxBalmus linked an issue Jun 4, 2025 that may be closed by this pull request
@MaxBalmus MaxBalmus marked this pull request as ready for review June 4, 2025 10:43
@LevanBokeria
Copy link
Collaborator

Looks good @MaxBalmus
If this model is going to be actively used and be part of the public facing package, shall I write a quick tests for it? I can just push the commits to this branch directly.

@MaxBalmus
Copy link
Collaborator Author

Thanks, @LevanBokeria, yes I plan to eventually have it replace the base version. Yes if you have some time to add some tests that would be great.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator Author

@MaxBalmus MaxBalmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@LevanBokeria LevanBokeria merged commit f546181 into dev Jun 5, 2025
2 checks passed
@LevanBokeria LevanBokeria deleted the 66-improved-contraction-pressure branch June 5, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved contraction pressure
2 participants