Bug fix batchrunner #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ooks 21 add pre commit hooks
…ted-models 58 separate out tested models
…applying-row-wise-instead-of-column-wise changing to axis=1 in _BatchRunner.py line 101.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the BatchRunner where operations on the self._samples DataFrame are now correctly applied row-wise instead of column-wise when n_jobs is set to 1.
- Fix changes the axis parameter for DataFrame.apply from 0 (column-wise) to 1 (row-wise) to align with the intended processing.
Comments suppressed due to low confidence (1)
src/ModularCirc/_BatchRunner.py:101
- Changing the axis value from 0 to 1 resolves the bug by applying the operation row-wise. Confirm that _run_case correctly handles each row as expected.
success = self._samples.apply(lambda row : self._run_case(row, **kwargs), axis=1)
|
All looks good |
MaxBalmus
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the operation to the self._samples dataframe row-wise instead of column-wise, when not parallellising the code.