Skip to content

fix: support both docker-compose and docker compose commands #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

fix: support both docker-compose and docker compose commands #26

merged 2 commits into from
May 28, 2025

Conversation

youssyml
Copy link

@youssyml youssyml commented May 28, 2025 •
edited
Loading

🤓 Why

Newer versions of Docker use docker compose instead of the legacy docker-compose command. The current mwaa-local-env script only supports the legacy command, causing compatibility issues for users with newer Docker installations.

💪 How

Added automatic detection of available docker compose command:

  • Checks for docker-compose (legacy standalone tool)
  • Falls back to docker compose (modern Docker CLI plugin)
  • Uses the detected command throughout the script
  • Updated validation to show which command is being used

🧪 Tests

  • I tested it with my local setup (using docker compose). Could you (dear reviewer) test it with your setup if it's docker-compose compatible ?

🤖 Generated with Claude Code

@youssyml @claude
fix: support both docker-compose and docker compose commands
277b432 
Detects whether docker-compose (legacy) or docker compose (modern Docker CLI)
is available and uses the appropriate command automatically.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
florian-ernst-alan
florian-ernst-alan approved these changes May 28, 2025
View reviewed changes
Copy link

@florian-ernst-alan florian-ernst-alan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I think a much simpler approach is to simply switch everything to docker compose (as it's been available for years, coexisting with docker-compose).

@youssyml youssyml merged commit 753e649 into main May 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChloePont ChloePont Awaiting requested review from ChloePont

@florian-ernst-alan florian-ernst-alan Awaiting requested review from florian-ernst-alan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@youssyml @florian-ernst-alan