-
Couldn't load subscription status.
- Fork 285
docs(notifications): Adds notification documentation #5265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5265 +/- ##
=======================================
Coverage 55.98% 55.98%
=======================================
Files 405 405
Lines 29858 29858
=======================================
Hits 16715 16715
Misses 12177 12177
Partials 966 966 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/send-message.md
Outdated
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/90-events/100-notifications/10-configuring-routers.md
Outdated
Show resolved
Hide resolved
65f5e5f to
b9f9252
Compare
| # The `namespace` field is ignored for `ClusterMessageChannel` as it is only allowed to reference | ||
| # Secrets in the cluster-secret-namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be ignored for MessageChannel as well, which is only allowed to reference Secrets in the Project's namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I've looked at that section as well, I do see it's called out as ignored there also. Now I'm wondering if that field should just go away since it's used in neither case. wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can remove references to it for sure. We are reusing the ObjectRef field in the actual CRD definition so the namespace is there no matter what
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely not something I feel we need to fix right this moment.
Devil's advocate... is there any reason it really needs to be an ObjectRef? If it were some other type that had only a name field, it's non-breaking to turn it back into an ObjectRef at some point in the future, should we need to.
I'm asking only because I always find it awkward when fields exist that one mustn't use, or can use but it will be ignored 100% of the time.
Again... not anything we need to put closure on here and now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think ObjectRef is in any way necessary. I picked it originally because it is the "canonical" way of referencing another object. Theoretically we could use the UID as well in the future. That isn't a good enough reason to keep it by any stretch of the imagination and I wouldn't mind trimming it to just a name
| having subscriptions to that repository, and request each to execute their | ||
| artifact discovery process. | ||
|
|
||
| ## Cluster Message Channels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an established way now of labeling entire pages as being EE features, but I'm not sure we have an established way yet of marking a section of a more general page with some indicator that it's EE only. I guess it's time to figure out an approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh... nevermind... sort of. I should have looked two lines down. Buuut... on pages where the entire page is exclusively EE content, these appear above the section heading. So there's a question about placement here maybe. No strong opinion here... just questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally think it makes more sense under a heading when in a page with "mixed" content. But I don't have a strong opinion here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're establishing the precedent here. If it's that it goes above the heading if it's the whole page and under the heading if it's a section of that page, I'm fine with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a heads up, when we put the span tag above the first H1, it messes up the automatic title in the sidebar. We can overwrite with sidebar_label, but this might be a reason we want to put everything below a heading (under the top H1 for a page where all the content is EE and under the specific section header for "mixed" content)
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/send-message.md
Outdated
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/send-message.md
Outdated
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/send-message.md
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/90-events/10-event-reference.md
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/90-events/10-event-reference.md
Outdated
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/90-events/10-event-reference.md
Outdated
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/90-events/10-event-reference.md
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/90-events/100-notifications/10-configuring-routers.md
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/90-events/100-notifications/10-configuring-routers.md
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/90-events/100-notifications/10-configuring-routers.md
Show resolved
Hide resolved
This adds full documentation for the new pro feature of Notifications. It includes both instructions for the imperative steps (`send-message` step) as well as the new `EventRouter` type for event-driven notifications Signed-off-by: Taylor Thomas <taylor.thomas@akuity.io>
Signed-off-by: Taylor Thomas <taylor.thomas@akuity.io>
b9f9252 to
ffb413f
Compare
This adds full documentation for the new pro feature of Notifications. It includes both instructions for the imperative steps (
send-messagestep) as well as the newEventRoutertype for event-driven notifications