-
Couldn't load subscription status.
- Fork 285
feat(server): Watch the tls certs for changes and update the served certs #4697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docs-kargo-io canceled.
|
|
I'd hold off on doing this until what's already here as been reviewed / agreed on, but the external webhooks server is probably in need of this exact same feature. |
|
@krancour is there anything else I need to do to get approval for the CI to run? |
This hasn't actually functionally changed from what the code was doing previously but I think it's being picked up now because I'm explicitly setting the This passed locally when I was testing but might be flaky so I'll check on it. |
They ran. Wonder if @hiddeco authorized it maybe. 🤷♂️
It's a little bit slower, but |
|
I've updated the minimum TLS version to be 1.3 and updated the flaking test to be more resilient. |
|
Is there anything else I can do to move this forward @krancour ? |
Signed-off-by: Dan Bason <dan.bason@dronedeploy.com>
|
@krancour we ran into this again recently in our infrastructure. I've rebased and updated the logging package but it would be great to get some idea how how you guys want to handle the certs and push it into the external webhook controller as well. |
Fixes #4617
Watches the certificate file locations (in a manner that is compatible with how k8s links and mounts secrets). Instead of passing the certificate files directly to the http server it uses GetCertificate instead, and updates the certificate when the files are changed.