fix the terminate error - std::logic_error issue on some OS environme… #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt and c-complier version
|
xlearn c++ code uses multi-threading, so while accessing the hardware it need the user variable in the environment. And because if c compiler version issue the init_log() parameter is empty. So we have to initialize it by ourself. |
|
Thanks @yoonkt200, this PR fixed the issue for me. I came across it when building xLearn with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the issue #311
some error cases when installed by pip in latest ubuntu(or CentOS). because of c compiler version issue, the
init_log()'s parameter is empty. maybe specify the parameter is needed.