Skip to content

Conversation

@popfido
Copy link
Contributor

@popfido popfido commented May 4, 2018

  • previously build.sh will try to install xlearn to all versions of python in a machine, which is quite unreasonable. This commit fix it and now build.sh only install xlearn to the current command line env's default python

- previously build.sh will try to install xlearn to all versions of python in a machine, which is quite unreasonable. This commit fix it and now build.sh only install xlearn to the current command line env's default python
@pkwv2012
Copy link
Contributor

pkwv2012 commented May 6, 2018

how about using the interactive install?
@popfido @aksnzhy

install xlearn for Python2? [y/n]
y
install xlearn for Python3? [y/n]
n

@popfido
Copy link
Contributor Author

popfido commented May 7, 2018

@purkyston I think ppl have clear acknowledgement that when they run this shell script, they want xlearn to be installed "exactly" into the python which the shell env currently use by default. If they want to install it into a non-default python, they will firstly enable the corresponding virtual env to ensure the "python" in current commandline env is the one they want to install xlearn.

@aksnzhy How do u think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants